fix(mysql): support DECIMAL/NEWDECIMAL decoding in tauri-plugin-sql#3286
Open
AbdenourTadjer33 wants to merge 2 commits intotauri-apps:v2from
Open
fix(mysql): support DECIMAL/NEWDECIMAL decoding in tauri-plugin-sql#3286AbdenourTadjer33 wants to merge 2 commits intotauri-apps:v2from
AbdenourTadjer33 wants to merge 2 commits intotauri-apps:v2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes MySQL decimal column decoding in
tauri-plugin-sql.Before this change, selecting rows containing
DECIMALcolumns could fail with:unsupported datatype: DECIMAL(when type was unhandled), ornulldecoded values (when trying incompatible string decoding).Root cause
src/decode/mysql.rsdid not properly decode MySQL decimal types through a compatible SQLx type.DECIMAL/NEWDECIMALrequire decimal-aware decoding in SQLx, not plainStringdecode compatibility.Changes
1) MySQL decode support
src/decode/mysql.rsDECIMALNEWDECIMALtry_decode::<BigDecimal>()to_string()This preserves precision and avoids float conversion loss.
2) Dependency feature
Cargo.tomlbigdecimalWhy JSON string output?
Decimal values are precision-sensitive (money/tax/rates).
Returning as string avoids precision loss and matches common JS/TS handling for fixed-point values.
Compatibility
Validation